Move Item and fetch to QueryData from WorldQuery
#17679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Carter0
approved these changes
Feb 4, 2025
chescock
approved these changes
Feb 4, 2025
Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
chescock
added
A-ECS
alice-i-cecile
added
the
M-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
alice-i-cecile
approved these changes
Feb 5, 2025
|
I've added a migration guide for you :) Really excellent stuff; thanks for tackling this. I hope it was fun and/or educational :D |
ElliottjPierce
added a commit
to ElliottjPierce/bevy
that referenced
this pull request
Feb 5, 2025
These were fixes from changes caused by bevyengine#17679
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 17, 2025
…17679) # Objective Fixes bevyengine#17662 ## Solution Moved `Item` and `fetch` from `WorldQuery` to `QueryData`, and adjusted their implementations accordingly. Currently, documentation related to `fetch` is written under `WorldQuery`. It would be more appropriate to move it to the `QueryData` documentation for clarity. I am not very experienced with making contributions. If there are any mistakes or areas for improvement, I would appreciate any suggestions you may have. ## Migration Guide The `WorldQuery::Item` type and `WorldQuery::fetch` method have been moved to `QueryData`, as they were not useful for `QueryFilter` types. --------- Co-authored-by: Chris Russell <8494645+chescock@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17662
Solution
Moved
ItemandfetchfromWorldQuerytoQueryData, and adjusted their implementations accordingly.Currently, documentation related to
fetchis written underWorldQuery. It would be more appropriate to move it to theQueryDatadocumentation for clarity.I am not very experienced with making contributions. If there are any mistakes or areas for improvement, I would appreciate any suggestions you may have.
Migration Guide
The
WorldQuery::Itemtype andWorldQuery::fetchmethod have been moved toQueryData, as they were not useful forQueryFiltertypes.